sam/libqbe
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

arm64/abi: fix big aggregates passed on the stack

Browse source 
The riscv test abi8.ssa caught a bug
in the arm backend. It turns out we
were using the wrong class when loading
pointers to aggregates from the stack.

The fix is simple and mirrors what is
done in the riscv abi.
This commit is contained in:
Quentin Carbonneaux 2022-03-14 09:59:14 +01:00
parent c7842d84da
commit 905e9cef30
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
arm64/abi.c
View file

@ -100,6 +100,9 @@ typclass(Class *c, Typ *t, int *gp, int *fp)
* memory */ * memory */
c->class |= Cptr; c->class |= Cptr;
c->size = 8; c->size = 8;
c->ngp = 1;
*c->reg = *gp;
*c->cls = Kl;
return; return;
} }
@ -230,14 +233,7 @@ argsclass(Ins *i0, Ins *i1, Class *carg, Ref *env)
case Oparc: case Oparc:
case Oargc: case Oargc:
typclass(c, &typ[i->arg[0].val], gp, fp); typclass(c, &typ[i->arg[0].val], gp, fp);
if (c->class & Cptr) { if (c->ngp <= ngp) {
if (ngp > 0) {
ngp--;
*c->reg = *gp++;
*c->cls = Kl;
break;
}
} else if (c->ngp <= ngp) {
if (c->nfp <= nfp) { if (c->nfp <= nfp) {
ngp -= c->ngp; ngp -= c->ngp;
nfp -= c->nfp; nfp -= c->nfp;